Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transpile nodesOfType #6408

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Fix transpile nodesOfType #6408

merged 1 commit into from
Jul 16, 2024

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented Jul 16, 2024

A spread with a Map/Set won't transpile well internally.

@vercel Vercel
Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 2:45pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 2:45pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2024
@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size
lexical - cjs 28.73 KB (0%)
lexical - esm 28.57 KB (0%)
@lexical/rich-text - cjs 37.2 KB (0%)
@lexical/rich-text - esm 28.13 KB (0%)
@lexical/plain-text - cjs 35.83 KB (0%)
@lexical/plain-text - esm 25.48 KB (0%)
@lexical/react - cjs 39.05 KB (0%)
@lexical/react - esm 29.48 KB (0%)

@zurfyx zurfyx added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit cad2861 Jul 16, 2024
42 of 45 checks passed
2wheeh pushed a commit to 2wheeh/lexical that referenced this pull request Jul 17, 2024
@zurfyx @2wheeh
Fix transpile nodesOfType (facebook#6408)
ea52da2
@phazingazrael phazingazrael mentioned this pull request Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantactuka fantactuka fantactuka approved these changes

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zurfyx @fantactuka @facebook-github-bot